Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release rancher and release charts GHA workflows #575

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Fix release rancher and release charts GHA workflows #575

merged 3 commits into from
Dec 23, 2024

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Dec 23, 2024

Issue rancher/rancher#46704

Best review commit by commit.

The changes are:

  • The default charts branch for this webhook release should be dev-v2.11
  • We're pulling r/r and r/charts with ref: specified to fix "commit dev-v2.11 does not exist"
  • The webhook branch cannot be obtained by github.event.inputs.ref so we're also fixing this

@tomleb tomleb requested a review from a team as a code owner December 23, 2024 15:59
@tomleb tomleb requested a review from nflynt December 23, 2024 15:59
nflynt
nflynt approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@nflynt nflynt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second time's a charm? 👍

@tomleb tomleb merged commit d2d9625 into rancher:main Dec 23, 2024
2 checks passed
@tomleb tomleb deleted the webhook-ci branch December 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflynt nflynt nflynt approved these changes

@pmatseykanets pmatseykanets pmatseykanets approved these changes

@joshmeranda joshmeranda Awaiting requested review from joshmeranda

@gehrkefc gehrkefc Awaiting requested review from gehrkefc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomleb @pmatseykanets @nflynt